Review Request 128004: fix alignment issue with the OS X native "macintosh" style

Elvis Angelaccio elvis.angelaccio at kdemail.net
Tue May 24 16:03:28 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128004/#review95746
-----------------------------------------------------------



Shouldn't this be fixed in Qt? Or is KCalc the only application exposing the bug?

Anyway, this doesn't break the KCalc layout on Linux, so it seems safe.

- Elvis Angelaccio


On May 24, 2016, 3:32 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128004/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 3:32 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Utils, Christoph Feck, and Elvis Angelaccio.
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> This fixes the alignment issue discussed at
> https://bugs.kde.org/show_bug.cgi?id=339670
> 
> 
> Diffs
> -----
> 
>   kcalc_button.cpp 47227c9 
> 
> Diff: https://git.reviewboard.kde.org/r/128004/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with KF5 frameworks 5.20.0, Qt 5.6.0 and KCalc 16.4.1 .
> 
> 
> File Attachments
> ----------------
> 
> kcalc using the native "macintosh" platform theme
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/087a7849-d593-45e6-886f-bdae9736b4c0__Screen_Shot_2016-05-24_at_17.23.14.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160524/10880da0/attachment.html>


More information about the Kde-utils-devel mailing list