[Differential] [Request, 24 lines] D1553: Fix broken corrupt query
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Sat May 7 11:44:32 UTC 2016
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.
REVISION SUMMARY
The LoadCorruptQuery is currently broken on master. Ark always loads a corrupt archive,
even if the user clicks `Don't Open`.
This is due to the `finished()` signal already emitted when the query pops up.
A simple fix is to run the query in `processFinished()`, if we detected that the
archive is corrupt.
TEST PLAN
Corrupt query works again.
REPOSITORY
rARK Ark
BRANCH
fix-corrupt-query
REVISION DETAIL
https://phabricator.kde.org/D1553
AFFECTED FILES
kerfuffle/cliinterface.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
More information about the Kde-utils-devel
mailing list