Review Request 127847: Fix invisible window with Qt 5.6

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127847/#review95211
-----------------------------------------------------------


Ship it!




Works for me :)

- Ragnar Thomsen


On May 5, 2016, 6:08 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127847/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 6:08 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 360105
>     http://bugs.kde.org/show_bug.cgi?id=360105
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> Since Qt 5.6, `minimumSize()` returns an empty size (`QSize(0, 0)`). 
> 
> This cause an invisible main window in KCalc, due to a `setFixedSize(minimumSize())` call.
> 
> This (new?) behavior is documented in the [QWidget api](http://doc.qt.io/qt-5/qwidget.html#minimumSize-prop), so it doesn't look like a bug in Qt.
> 
> The proper way to set a fixed size (based on the actual content) is to use `QLayout::setSizeConstraint()`, as suggested by the [documentation](http://doc.qt.io/qt-5/qwidget.html#setFixedSize) of `setFixedSize()` itself.
> 
> 
> Diffs
> -----
> 
>   kcalc.cpp 13b7bd3 
>   kcalc.ui 7511ffe 
> 
> Diff: https://git.reviewboard.kde.org/r/127847/diff/
> 
> 
> Testing
> -------
> 
> KCalc is now visible again with Qt 5.6. The main window size is fixed as before.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160505/8ea7a739/attachment.html>