[Differential] [Requested Changes To] D1268: Enable support for setting compression level in cliplugins

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Thu Mar 31 09:51:43 UTC 2016


elvisangelaccio requested changes to this revision.
This revision now requires changes to proceed.

INLINE COMMENTS
  kerfuffle/cliinterface.cpp:723 Some kind of input validation would be useful here. Say that the level is negative (should not happen, but who knows), in that case the function should return an empty list (and the plugin would then use whatever the default level is.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1268

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list