[Differential] [Request, 236 lines] D1190: Sanitize replacement of CLI args

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio added a subscriber: kde-utils-devel.
elvisangelaccio set the repository for this revision to rARK Ark.
elvisangelaccio added a project: Ark.

REVISION SUMMARY
  The code where the CLI arguments are substitued (in `CliInterface::copyFiles()`) is a nightmare and works only by chance. The cliunarchiver plugin exposed a bug in (at least) the replacement of `PasswordSwitch`.
  
  The only way to fix it is to trash the old algorithm and rewrite it from scratch. We do don't anymore black magic with the indexes, to edit the args list. We just create a new empty list and we append stuff to it.
  
  New functions are introduced to simplify the for loop.

TEST PLAN
  Autotests still pass, but this is a core piece of the codebase, so let's make sure that nothing breaks... :)

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1190

AFFECTED FILES
  kerfuffle/cliinterface.cpp
  kerfuffle/cliinterface.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara