[Differential] [Requested Changes To] D1165: Improve ExtractionDialog

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  The bugfix works for me!

INLINE COMMENTS
  kerfuffle/extractiondialog.cpp:103 "ExtractioDialog::slotAccepted() called" would be more useful.
  Or maybe even drop this debug line?
  kerfuffle/extractiondialog.cpp:106 You can save one indentation level here.
  
  
  ```
  if (fileWidget->dirOperator()->selectedItems().isEmpty()) {
     // code for setUrl()
     ...
     return;
  }
  
  // code for normal extraction.
  ...
  ```
  kerfuffle/extractiondialog.cpp:110 Double ampersand.
  kerfuffle/extractiondialog.cpp:112 Maybe `QUrl::fromLocalFile()` here?

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1165

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara