Review Request 110943: Adds basic lzo support

[David Hallas]

> On Jan. 15, 2016, 12:09 p.m., Elvis Angelaccio wrote:
> > Hi David. Sorry for the delay.
> > 
> > Are you still interested in working on LZO support?
> > Your patch looks promising, but should be ported to the KDE Frameworks 5.
> 
> David Hallas wrote:
>     Hi Elvis,
>     
>     yes certainly. Can you give me some pointers where to start with porting the code to Frameworks 5?
>     
>     Thanks!
> 
> Elvis Angelaccio wrote:
>     > Can you give me some pointers where to start with porting the code to Frameworks 5?
>     
>     Your best bet is looking at how the Ark plugins are currently implemented. In the Ark repository, start from the `plugins/cliplugin-example` folder and then look at some actual plugin. Basically you are supposed to:
>     
>     1. Update your `CMakeLists.txt` file, until you are able to run cmake without errors
>     2. Add the `K_PLUGIN_FACTORY` macro in your `cliplugin.cpp`
>     3. Port `cliplugin.cpp` to Qt5/KF5. Since there is not much code there, it shouldn't be too hard. For instance, you will have to replace `kDebug()` with `qCDebug(ARK)`, and so on. Please refer to the official porting guide: https://community.kde.org/Frameworks/Porting_Notes
>     
>     If you have questions or problems, feel free to ask here or on IRC (in the #kde-utils channel).
>     
>     Good luck!
> 
> Ragnar Thomsen wrote:
>     I think it is better to enable support for lzop-compressed tars in the libarchive plugin than to add and maintain an additional cliplugin.
> 
> Elvis Angelaccio wrote:
>     > I think it is better to enable support for lzop-compressed tars in the libarchive plugin than to add and maintain an additional cliplugin.
>     
>     If that is possible, yes it would be better. David, what's the status of your patch?
> 
> David Hallas wrote:
>     I have attached the current patch, it is still work in progress, but it can be picked up and completed with a little dedicated effor. Unfortunately I have not had time to finish it yet :(
> 
> Ragnar Thomsen wrote:
>     I have enabled support for tar.lzo archives in the libarchive plugin (commit 17df27dab76bad4ce5bf78e1a1240408d972ef88). This will be available in Ark 16.04. I think we can discard this RR?

Yes - if you have already added support then there is no reason for this review request - please close it :)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110943/#review91137
-----------------------------------------------------------


On June 10, 2013, 7:22 p.m., David Hallas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110943/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 7:22 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 211669
>     http://bugs.kde.org/show_bug.cgi?id=211669
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch adds basic lzo support using lzop. I want to get some early feedback before completing the code
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt 3619412 
>   plugins/clilzopplugin/CMakeLists.txt PRE-CREATION 
>   plugins/clilzopplugin/cliplugin.h PRE-CREATION 
>   plugins/clilzopplugin/cliplugin.cpp PRE-CREATION 
>   plugins/clilzopplugin/kerfuffle_clilzop.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/110943/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Hallas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160314/0f1f77ed/attachment.html>