[Differential] [Requested Changes To] D1111: When packing multiple selected files - use containing folder name

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  The logic for the bugfix looks ok.
  But I would prefer to move this new code to a dedicated function ;)

INLINE COMMENTS
  kerfuffle/addtoarchive.cpp:162 How about introducing a new (public) function?
  You would then do something like `const QString base = detectBaseName(m_input);`
  
  This would allow us to easily unit test it, in the future.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1111

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: tctara, rthomsen, elvisangelaccio
Cc: kde-utils-devel, Ark, tctara