[Differential] [Requested Changes To] D1098: Add support for lzipped archives
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Thu Mar 10 21:04:24 UTC 2016
elvisangelaccio requested changes to this revision.
This revision now requires changes to proceed.
INLINE COMMENTS
autotests/kerfuffle/archivetest.cpp:286 `QString()` instead of `QStringLiteral("")`, same for the other occurrences below.
kerfuffle/createdialog.cpp:254 Opening brace after the new line, same for CreateDialog::currentFilterMimeType()
kerfuffle/createdialog.h:53 Since these are public, better not use the `m_` prefix scheme.
kerfuffle/createdialog.h:81 Missing `const`.
kerfuffle/createdialog.h:82 If this function accepted a QString with the `name()` of the mimetype, the patch would be a bit simpler:
* The mimetype is already saved as string in arkrc
* No need to use the `QMimeDatabase` in the tests or in other places
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D1098
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
More information about the Kde-utils-devel
mailing list