[Differential] [Requested Changes To] D1095: Fix the QuickExtract menu
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Wed Mar 9 18:58:23 UTC 2016
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
Nice work, just some little changes :)
INLINE COMMENTS
kerfuffle/extractiondialog.cpp:158 We already have an "ExtractDialog" config group name, let's re-use it. No need to create a new group with name "ExtractDialog DirHistory" ;)
kerfuffle/extractiondialog.cpp:159 Please call this entry "DirHistory", which is more explicative than "Item".
kerfuffle/extractiondialog.cpp:165 Same here, "DirHistory" instead of "Item".
part/part.cpp:453 Same here, change the name of the config group and the entry below.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D1095
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: tctara, rthomsen, elvisangelaccio
Cc: kde-utils-devel, Ark, tctara
More information about the Kde-utils-devel
mailing list