Review Request 127017: Fix click event for constant buttons

Luigi Toscano luigi.toscano at tiscali.it
Tue Mar 8 22:20:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127017/
-----------------------------------------------------------

(Updated March 8, 2016, 10:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils, Christoph Feck, Rolf Eike Beer, Laurent Montel, and Evan Teran.


Changes
-------

Submitted with commit a4dfbe234f8a6d1a052c36e535be60f030bf35ca by Luigi Toscano to branch Applications/15.12.


Bugs: 353644
    http://bugs.kde.org/show_bug.cgi?id=353644


Repository: kcalc


Description
-------

It looks like the new style of "connect" tries to use the clicked signal as defined inside the function, which does not trigger slotClicked(). This change explicitly use the clicked signal from the (grand)parent class and the expected chain of signal/slots triggering is restored.
(that said, I'm not too expert on debugging the internals of the signal/slot system, so I may have guessed incorrectly).


Diffs
-----

  kcalc_const_button.cpp 443abb6 

Diff: https://git.reviewboard.kde.org/r/127017/diff/


Testing
-------

Constant buttons can be clicked again


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160308/424e94be/attachment.html>


More information about the Kde-utils-devel mailing list