Review Request 127017: Fix click event for constant buttons

[Rolf Eike Beer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127017/#review93311
-----------------------------------------------------------


Ship it!




According to what I know one needs to use the class that introduced the signal, so this change seems correct.

- Rolf Eike Beer


On März 7, 2016, 12:18 vorm., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127017/
> -----------------------------------------------------------
> 
> (Updated März 7, 2016, 12:18 vorm.)
> 
> 
> Review request for KDE Utils, Christoph Feck, Rolf Eike Beer, Laurent Montel, and Evan Teran.
> 
> 
> Bugs: 353644
>     http://bugs.kde.org/show_bug.cgi?id=353644
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> It looks like the new style of "connect" tries to use the clicked signal as defined inside the function, which does not trigger slotClicked(). This change explicitly use the clicked signal from the (grand)parent class and the expected chain of signal/slots triggering is restored.
> (that said, I'm not too expert on debugging the internals of the signal/slot system, so I may have guessed incorrectly).
> 
> 
> Diffs
> -----
> 
>   kcalc_const_button.cpp 443abb6 
> 
> Diff: https://git.reviewboard.kde.org/r/127017/diff/
> 
> 
> Testing
> -------
> 
> Constant buttons can be clicked again
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160308/2b9af8bd/attachment.html>