[Maniphest] [Created] T1771: Run CliInterface from the main thread

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Sun Mar 6 19:58:35 UTC 2016


elvisangelaccio created this task.
elvisangelaccio moved this task to Backlog on the Ark workboard.

TASK DESCRIPTION
  Moved here from: https://bugs.kde.org/show_bug.cgi?id=264219
  
  Original description by Rapheal:
  
  > We already use a QProcess in CliInterface, so there should be no reason for also running it from a separate thread. Besides all the hell associated to running threaded code, it is unnecessary and causes problems with main loops such as the one in CliInterface::runProcess() -- if CliInterface::failOperation() is called (when a wrong password is entered in a header-protected file), KJob::emitResult() will end up being called somewhere in the call stack, and will terminate the auxiliary thread running our QProcess, finishing the event loop before the process is terminated correctly.

TASK DETAIL
  https://phabricator.kde.org/T1771

WORKBOARD
  https://phabricator.kde.org/project/board/46/

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio
Cc: kde-utils-devel, elvisangelaccio, tctara


More information about the Kde-utils-devel mailing list