[Differential] [Requested Changes To] D1821: Add support for LZ4-compressed tar archives

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:9
>  
> +if(LibArchive_FOUND)
> +  if(LibArchive_VERSION VERSION_EQUAL "3.2.0" OR

This `if()` is always going to be true, since libarchive is a required dep. So you can drop  it (same for all the `if()`s below)

> CMakeLists.txt:79
> +     LibArchive_VERSION VERSION_GREATER "3.2.0")
> +    target_compile_definitions(kerfuffle_libarchive PRIVATE -DHAVE_LIBARCHIVE_3_2_0)
> +  endif()

This can be moved in the previous if().

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1821

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160613/c1cc7d0b/attachment.html>