Review Request 128060: Fix handling command line arguments

[Urs Wolfer]

> On May 31, 2016, 7:31 p.m., Urs Wolfer wrote:
> > main.cpp, line 121
> > <https://git.reviewboard.kde.org/r/128060/diff/1/?file=467305#file467305line121>
> >
> >     Why don't use QUrl::fromUserInput anymore like in the last review request?
> 
> Arno Möller wrote:
>     Because then we can't default to vnc any more if the user passes just a hostname on the command line. With QUrl::fromUserInput()
>     $ krdc 127.0.0.1
>     becomes
>     $ krdc http://127.0.0.1
>     but we want vnc://127.0.0.1.
>     QUrl::fromUserInput() basically does some guesswork to construct a valid URL for a *web* application, so using QUr::QUrl() is easier in our case.

I have not forgot about your changes - I just need some time until I get back to it again. Sorry.


- Urs


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128060/#review96109
-----------------------------------------------------------


On May 30, 2016, 4:24 p.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128060/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 4:24 p.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> QUrl::fromLocalFile is clearly wrong. It gives us file://rdp:// or similar garbage.
> 
> We cannot use QUrl::fromUserInput() either, since this gives us an http:// or an ftp:// URL if the scheme is empty, depending on the hostname. Due to the plugin architecture we cannot assume
> that krdc can't handle those protocols.
>     
> Assume that we're dealing with just a hostname instead, and further assume that the protocol is vnc:// (default since kde3).
> 
> 
> Diffs
> -----
> 
>   main.cpp 73093f3 
> 
> Diff: https://git.reviewboard.kde.org/r/128060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160612/1ca5bd9c/attachment-0001.html>