[Differential] [Request, 37 lines] D1829: Use setupGUI() in MainWindow

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio added a subscriber: kde-utils-devel.
elvisangelaccio set the repository for this revision to rARK Ark.
elvisangelaccio added a project: Ark.

REVISION SUMMARY
  `MainWindow `inherits from `KXmlGuiWindow`, but we never call `KXmlGuiWindow::setupGUI()`. This is bad because we lose a lot of things (for example the "Show Toolbar" checkbox in the Settings menu) that we have to manually provide (e.g. the configure shortcuts/toolbar dialogs).
  
  Calling `setupGUI()` also ensures that the window size be automatically restored (`setAutoSaveSettings()` is implicitly called).
  The call to `resize()` is also useless (640x480 seems to be already the default) and possibly bad, according to: https://api.kde.org/frameworks/kxmlgui/html/classKMainWindow.html#a421a8ca496cd11ff388b630357735cf4

TEST PLAN
  Check whether is still possible to edit shortcuts and the toolbar.
  Check whether the new "Show Toolbar" checkbox works.
  
  This also fixes bug 357660: https://bugs.kde.org/show_bug.cgi?id=357660

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1829

AFFECTED FILES
  app/mainwindow.cpp
  app/mainwindow.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160612/ebb95e32/attachment.html>