[Differential] [Request, 294 lines] D1822: Stop hardcoding mimetypes in the libarchive json files
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Sat Jun 11 09:35:10 UTC 2016
elvisangelaccio created this revision.
elvisangelaccio added reviewers: rthomsen, lueck.
elvisangelaccio added a subscriber: kde-utils-devel.
elvisangelaccio set the repository for this revision to rARK Ark.
elvisangelaccio added a project: Ark.
REVISION SUMMARY
In order to not hard-depend on libarchive 3.2, we need to be able to configure the supported mimetypes at build time (depending on whether we are building against libarchive 3.1.2 or 3.2).
This means we cannot hardcode the supported mimetypes in the json files of the libarchive plugins.
TEST PLAN
Build and check the generated json files in $BUILD_DIR/plugins/libarchive
Tests still pass.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D1822
AFFECTED FILES
plugins/libarchive/CMakeLists.txt
plugins/libarchive/kerfuffle_libarchive.json
plugins/libarchive/kerfuffle_libarchive.json.cmake
plugins/libarchive/kerfuffle_libarchive_readonly.json
plugins/libarchive/kerfuffle_libarchive_readonly.json.cmake
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, rthomsen, lueck
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160611/68a5aed6/attachment-0001.html>
More information about the Kde-utils-devel
mailing list