[Differential] [Request, 78 lines] D2303: Fix detection of broken 7z multivolumes archives

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  The crash we were facing can be fixed by refactoring `handleLine()`. The function
  now just returns a boolean and the task of calling `killProcess()` is moved to the
  caller (`readStdout()`).

TEST PLAN
  Doesn't crash anymore when opening a broken multipart 7z.
  Let's make sure this doesn't break anything else...

REPOSITORY
  rARK Ark

BRANCH
  fix-handleLine

REVISION DETAIL
  https://phabricator.kde.org/D2303

AFFECTED FILES
  kerfuffle/cliinterface.cpp
  kerfuffle/cliinterface.h
  plugins/cli7zplugin/cliplugin.cpp
  plugins/cliunarchiverplugin/cliplugin.cpp
  plugins/cliunarchiverplugin/cliplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160727/cfbb7208/attachment.html>