[Differential] [Request, 114 lines] D2291: Add testcases for multivolume rar and 7z archives to ArchiveTest::testProperties()
rthomsen (Ragnar Thomsen)
noreply at phabricator.kde.org
Tue Jul 26 17:20:23 UTC 2016
rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.
REVISION SUMMARY
We test an additional property (isMultiVolume) which requires that we list the archive. The test revealed a bug in Archive::completeBaseName() where the basename for multi-volume archives wasn't computed correctly.
F201940: archive-multivolume.7z.001 <https://phabricator.kde.org/F201940>
F201942: archive-multivolume.7z.002 <https://phabricator.kde.org/F201942>
F201943: archive-multivolume.7z.003 <https://phabricator.kde.org/F201943>
F201944: archive-multivolume.part1.rar <https://phabricator.kde.org/F201944>
F201945: archive-multivolume.part2.rar <https://phabricator.kde.org/F201945>
F201946: archive-multivolume.part3.rar <https://phabricator.kde.org/F201946>
TEST PLAN
- The unit test passes.
- When extracting a multi-volume archive, the suggested foldername does not contain `.partNN`, `.zip` or `.7z`.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D2291
AFFECTED FILES
autotests/kerfuffle/archivetest.cpp
kerfuffle/archive_kerfuffle.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160726/b2a11fe6/attachment.html>
More information about the Kde-utils-devel
mailing list