Review Request 128496: Make default protocol configurable

Urs Wolfer uwolfer at kde.org
Fri Jul 22 06:10:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128496/#review97743
-----------------------------------------------------------




core/krdc.kcfg (line 63)
<https://git.reviewboard.kde.org/r/128496/#comment65838>

    Please use same indention as used around your change.


- Urs Wolfer


On July 22, 2016, 3:22 a.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128496/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 3:22 a.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> Add a new config option for the default protocol.
> Default protocol: protocol to use when passing a hostname via command line without a scheme.
> ~~
> $ krdc my.host
> ~~
> expands to vnc://my.host since the dawn of time. With the default protocol set to "rdp" it expands to rdp://my.host
> 
> The default protocol defaults to vnc to keep the current behavior.
> 
> It's a QString because I have no clue how to gather the supported protocols from all installed plugins.
> 
> 
> Diffs
> -----
> 
>   config/general.ui 4a1f0e0 
>   core/krdc.kcfg 17d80ef 
>   main.cpp d702bf2 
> 
> Diff: https://git.reviewboard.kde.org/r/128496/diff/
> 
> 
> Testing
> -------
> 
> $ krdc my.host
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160722/e93d181c/attachment.html>


More information about the Kde-utils-devel mailing list