[Differential] [Request, 112 lines] D2229: Fix extraction when an archive has a percentage in the name

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Tue Jul 19 20:21:13 UTC 2016


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  QUrl::toDisplayString() results in a QString containing %25 instead of %,
  breaking a lot of stuff. Porting to QUrl::toLocalFile() fixes this issue (bug
  365798).
  
  A similar fix should be applied also to AddToArchive jobs.

TEST PLAN
  BatchExtract job is unit tested.
  
  Normal extraction to a subfolder with percentage in the name also work as
  expected.

REPOSITORY
  rARK Ark

BRANCH
  tests/batchextract

REVISION DETAIL
  https://phabricator.kde.org/D2229

AFFECTED FILES
  app/batchextract.cpp
  autotests/CMakeLists.txt
  autotests/app/CMakeLists.txt
  autotests/app/batchextracttest.cpp
  autotests/app/data/simple%archive.tar.gz
  part/part.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160719/25a87da9/attachment-0001.html>


More information about the Kde-utils-devel mailing list