Review Request 128414: Port away from KInputDialog

Christoph Feck cfeck at kde.org
Tue Jul 19 13:25:27 UTC 2016



> On July 18, 2016, 7:07 p.m., Christoph Feck wrote:
> > The changes in the #include section suggests you wanted to port to QInputDialog. Why was this not possible?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     I couldn't get figure out how to set the proper validator.

Right. https://bugreports.qt.io/browse/QTBUG-4146 for reference.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128414/#review97561
-----------------------------------------------------------


On July 18, 2016, 9:33 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128414/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 9:33 p.m.)
> 
> 
> Review request for KDE Utils and Valentin Rusu.
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> This is the last of kdelibs4support. Now only some deprecated methods from Qt left.
> 
> 
> Diffs
> -----
> 
>   src/manager/kwalletmanager.cpp f978c02 
> 
> Diff: https://git.reviewboard.kde.org/r/128414/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160719/cecb998e/attachment.html>


More information about the Kde-utils-devel mailing list