[Differential] [Requested Changes To] D2196: Disable adding files to existing password-protected non-header-encrypted archives

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> part.cpp:420
> +    // archive with a mixture of encrypted and unencrypted files.
> +    bool isEncryptedButUnknownPassword = m_model->archive() &&
> +                                         m_model->archive()->encryptionType() != Archive::Unencrypted &&

const bool

> part.cpp:425
> +    if (isEncryptedButUnknownPassword) {
> +        m_addFilesAction->setToolTip(i18nc("@info:tooltip",
> +                                           "Adding files to existing password-protected archives with no header-encryption is currently not supported."));

Use `xi18nc`, which will nicely split this long sentence across multiple lines. You can even re-add the "workaround" sentence ("Extract the files and...").

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2196

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160718/0b48ac89/attachment-0001.html>