Review Request 128415: Port away from deprecated Qt methods

Christoph Feck cfeck at kde.org
Mon Jul 18 19:10:41 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128415/#review97562
-----------------------------------------------------------


Ship it!




Ship It!


CMakeLists.txt (line 46)
<https://git.reviewboard.kde.org/r/128415/#comment65781>

    Could you sort these alphabetically?


- Christoph Feck


On July 9, 2016, 7:50 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128415/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 7:50 p.m.)
> 
> 
> Review request for KDE Utils and Valentin Rusu.
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> After this patch, plus the two others, KDELibs4Support can be removed from the CMakeLists.txt files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b7ce3bb62cf40f159395ee098a85666abf164ec6 
>   src/konfigurator/konfigurator.cpp e4fa19fca324a12e07cf750886a494d207d95793 
>   src/manager/kwalleteditor.cpp 7c4229ba409b50b75a367a6591bed5680759df75 
>   src/manager/kwalletmanager.h 91993389158d4a3753f6f39417bd6ab4beb90d96 
>   src/manager/kwalletmanager.cpp 64a90ddb77d036252fc0907a871b6a00e00cdf61 
> 
> Diff: https://git.reviewboard.kde.org/r/128415/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160718/87417313/attachment.html>


More information about the Kde-utils-devel mailing list