[Differential] [Request, 69 lines] D2123: Improve checksums calculation

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Fri Jul 8 21:50:38 UTC 2016


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  1. Compute also the MD5 in another thread (useful if the archive is huge)
  2. Drop the member QByteArray. If the archive is huge this could be bad on systems with low amount of RAM. QCryptographicHash accepts a QIODevice, so we can just read the file three times.

REPOSITORY
  rARK Ark

BRANCH
  refactor/checksum

REVISION DETAIL
  https://phabricator.kde.org/D2123

AFFECTED FILES
  kerfuffle/propertiesdialog.cpp
  kerfuffle/propertiesdialog.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160708/270a7a23/attachment.html>


More information about the Kde-utils-devel mailing list