[Differential] [Changed Subscribers] D2120: Implement a custom AddDialog

ltoscano (Luigi Toscano) noreply at phabricator.kde.org
Fri Jul 8 21:22:29 UTC 2016


ltoscano added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in part.cpp:1244
> The name of the actions and the title of the dialog are not consistent:
> 
> - Action in the menu => `Add File...`
> - Action in the toolbar => `Add File`
> - Title of the dialog => `Add Files`
> 
> Not sure what should we do, though...

If the result of the action (through a dialog in this case) allows to add multiple files, then it should be Add Files, yes - but no ellipsis in the dialog title, only in the menu.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: ltoscano, kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160708/e35efe4e/attachment.html>


More information about the Kde-utils-devel mailing list