[Differential] [Request, 1,173 lines] D2120: Implement a custom AddDialog

rthomsen (Ragnar Thomsen) noreply at phabricator.kde.org
Fri Jul 8 15:43:21 UTC 2016


rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.

REVISION SUMMARY
  This diff implements an AddDialog class that is used instead of QFileDialogs for adding files/folders to an archive. Now both folders and files are added to an archive with a single action in Part, instead of the two separate actions (Add File/Add Folder).
  
  AddDialog has a button which opens a new dialog that allows setting advanced compression settings (currently only compression level). Since compression options are used both when creating a new archive and adding files to an existing archive, a new class called CompressionOptionsWidget was created which is used by both AddDialog and CreateDialog.

TEST PLAN
  - Add file(s) to an archive.
  - Add folder(s) to an archive.
  - Add both files(s) and folder(s) simultaneously.
  - Try customizing compression level.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2120

AFFECTED FILES
  autotests/kerfuffle/CMakeLists.txt
  autotests/kerfuffle/adddialogtest.cpp
  kerfuffle/CMakeLists.txt
  kerfuffle/adddialog.cpp
  kerfuffle/adddialog.h
  kerfuffle/archive_kerfuffle.cpp
  kerfuffle/archive_kerfuffle.h
  kerfuffle/compressionoptionswidget.cpp
  kerfuffle/compressionoptionswidget.h
  kerfuffle/compressionoptionswidget.ui
  kerfuffle/createdialog.cpp
  kerfuffle/createdialog.h
  kerfuffle/createdialog.ui
  part/ark_part.rc
  part/part.cpp
  part/part.h
  plugins/libarchive/readwritelibarchiveplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160708/a54c96a3/attachment.html>


More information about the Kde-utils-devel mailing list