[Differential] [Request, 7 lines] D2114: Reset comment widget when opening an archive.

rthomsen (Ragnar Thomsen) noreply at phabricator.kde.org
Thu Jul 7 16:53:20 UTC 2016


rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.

REVISION SUMMARY
  When creating a new archive from an Ark instance where an archive with comment already is opened, the comment widget from the previous archive remains open. This is now fixed by clearing and hiding the QPlaintTextEdit in start of Part::openFile().
  
  Part::slotCommentChanged() gets called when calling QPlainTextEdit::clear(), so to avoid a segfault we need to check for a invalid m_model.archive() and in that case return.

TEST PLAN
  1. Open any archive with a comment.
  2. Create a new archive from Archive menu.
  3. Verify that the comment field from the previous archive disappears.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2114

AFFECTED FILES
  part/part.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160707/7b7f8ce3/attachment.html>


More information about the Kde-utils-devel mailing list