Review Request 128380: Bring back the progress thing.

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Wed Jul 6 13:31:31 UTC 2016



> On July 5, 2016, 5:43 p.m., Andrius Štikonas wrote:
> > I tested and it works. But I noticed that the icon changes back from breeze icon to the older style icon (I guess the ones still shipped in the source). Not sure what to do about that...

I have seen earlier that KIconLoader and QIcon::fromTheme doesn't seem to load the same icon, so it might be better with my latest version of the patch where I switched to using KIconLoader.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128380/#review97130
-----------------------------------------------------------


On July 6, 2016, 1:30 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128380/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 1:30 p.m.)
> 
> 
> Review request for KDE Utils and Laurent Montel.
> 
> 
> Bugs: 279222
>     http://bugs.kde.org/show_bug.cgi?id=279222
> 
> 
> Repository: kteatime
> 
> 
> Description
> -------
> 
> This brings back the progress indicator.
> 
> 
> Diffs
> -----
> 
>   src/toplevel.h e3a4f6d 
>   src/toplevel.cpp c0d5b72 
> 
> Diff: https://git.reviewboard.kde.org/r/128380/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160706/f86e3055/attachment.html>


More information about the Kde-utils-devel mailing list