Review Request 128354: Fix wrong path to existing wallet files

Burkhard Lück lueck at hube-lueck.de
Mon Jul 4 10:57:14 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128354/
-----------------------------------------------------------

Review request for KDE Utils and Valentin Rusu.


Bugs: 358469 and 363532
    http://bugs.kde.org/show_bug.cgi?id=358469
    http://bugs.kde.org/show_bug.cgi?id=363532


Repository: kwalletmanager


Description
-------

the wallet files *.kwl + *.salt are located in a subdir "/kwalletd/" in QStandardPaths::GenericDataLocation
see 
kwalletmanager.cpp:390:    const QString path = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/kwalletd/";
kwalletmanager.cpp:420:    const QString destinationDir = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/kwalletd/";

But the code uses QStandardPaths::DataLocation) + "/kwallet/" therefore existing wallet files are not found
and the config entries "Auto Allow" and "Auto Deny" are always deleted


Diffs
-----

  src/konfigurator/konfigurator.cpp e4fa19f 

Diff: https://git.reviewboard.kde.org/r/128354/diff/


Testing
-------

With the patch the config entries "Auto Allow" and "Auto Deny" are preserved in kwalletrc


Thanks,

Burkhard Lück

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160704/b2a3e887/attachment.html>


More information about the Kde-utils-devel mailing list