Review Request 122376: libarchive: throw error on extracting fail

Boris Egorov egorov at linux.com
Fri Jan 15 14:15:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122376/
-----------------------------------------------------------

(Updated Jan. 15, 2016, 2:15 p.m.)


Status
------

This change has been discarded.


Review request for KDE Utils and Raphael Kubo da Costa.


Bugs: 206383
    http://bugs.kde.org/show_bug.cgi?id=206383


Repository: ark


Description
-------

Ark can't continue extraction after libarchive fail anyway, so let's instead throw an error. Such error can appear when disk is full, for example. Error progpagated to UI and shown to user. Error message currently a little verbose ("Cannot extract file.txt: Can't create 'file.txt'") for now.


Diffs
-----

  plugins/libarchive/libarchivehandler.cpp 0fba528 

Diff: https://git.reviewboard.kde.org/r/122376/diff/


Testing
-------

Make sure build is fine, then:

dd if=/dev/zero of=linux-ark bs=1024 count=100
sudo mke2fs linux-ark
sudo mount tmp/linux-ark /mnt/
cd /mnt
mkdir extract
ark -b -o extract /path/to/some/archive.zip


Thanks,

Boris Egorov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160115/0a6a6323/attachment.html>


More information about the Kde-utils-devel mailing list