Review Request 110943: Adds basic lzo support

[Elvis Angelaccio]

> On Jan. 15, 2016, 12:09 p.m., Elvis Angelaccio wrote:
> > Hi David. Sorry for the delay.
> > 
> > Are you still interested in working on LZO support?
> > Your patch looks promising, but should be ported to the KDE Frameworks 5.
> 
> David Hallas wrote:
>     Hi Elvis,
>     
>     yes certainly. Can you give me some pointers where to start with porting the code to Frameworks 5?
>     
>     Thanks!

> Can you give me some pointers where to start with porting the code to Frameworks 5?

Your best bet is looking at how the Ark plugins are currently implemented. In the Ark repository, start from the `plugins/cliplugin-example` folder and then look at some actual plugin. Basically you are supposed to:

1. Update your `CMakeLists.txt` file, until you are able to run cmake without errors
2. Add the `K_PLUGIN_FACTORY` macro in your `cliplugin.cpp`
3. Port `cliplugin.cpp` to Qt5/KF5. Since there is not much code there, it shouldn't be too hard. For instance, you will have to replace `kDebug()` with `qCDebug(ARK)`, and so on. Please refer to the official porting guide: https://community.kde.org/Frameworks/Porting_Notes

If you have questions or problems, feel free to ask here or on IRC (in the #kde-utils channel).

Good luck!


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110943/#review91137
-----------------------------------------------------------


On June 10, 2013, 7:22 p.m., David Hallas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110943/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 7:22 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 211669
>     http://bugs.kde.org/show_bug.cgi?id=211669
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch adds basic lzo support using lzop. I want to get some early feedback before completing the code
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt 3619412 
>   plugins/clilzopplugin/CMakeLists.txt PRE-CREATION 
>   plugins/clilzopplugin/cliplugin.h PRE-CREATION 
>   plugins/clilzopplugin/cliplugin.cpp PRE-CREATION 
>   plugins/clilzopplugin/kerfuffle_clilzop.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/110943/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Hallas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160115/b4349f01/attachment.html>