Review Request 123832: libarchive: Improve the handling of archive_write_header() errors.

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123832/#review91135
-----------------------------------------------------------



Hi Raphael. This patch has been superseded by this [commit](https://phabricator.kde.org/rARKb385b8657470b3f65bd379b35abf9aa279f91e44) from Ragnar. Could you please discard this request?

- Elvis Angelaccio


On May 31, 2015, 2:39 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123832/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 2:39 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 206383 and 335411
>     http://bugs.kde.org/show_bug.cgi?id=206383
>     http://bugs.kde.org/show_bug.cgi?id=335411
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Errors while extracting an archive entry in copyFiles() were being
> discarded without informing the user, who would then believe the entire
> extraction had worked correctly. We now emit the error() signal when
> there is an error and cancel the extraction.
> 
> Other callers of archive_write_header() have also been modified to use
> the same coding style (handling errors in a switch()) and error message
> format for consistency and ease of future maintenance.
> 
> Additionally, none of the error messages use archive_error_string()
> anymore. While this means the messages are less detailed, it also means
> users who use a translated KDE will not see part of the error messages
> hardcoded in English.
> 
> 
> Diffs
> -----
> 
>   plugins/libarchive/libarchivehandler.cpp 75cf759d5e67508288ee6a42d42b4c0d6b557afe 
> 
> Diff: https://git.reviewboard.kde.org/r/123832/diff/
> 
> 
> Testing
> -------
> 
> Creating archives still works as before, and error messages during extraction (such as the one in bug 335411) are properly reported.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160115/954a1cda/attachment.html>