[Differential] [Request, 12 lines] D745: Fix some nested xi18n call

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Tue Jan 5 14:56:53 UTC 2016


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Herald added a subscriber: kde-utils-devel.

REVISION SUMMARY
  xi18n calls cannot be nested, otherwise the markup gets messed up.
  Plugins should use kxi18n instead, but that returns a
  KLocalizedString which is not a QString and would require us to change the
  ArchiveInterface API.
  
  So an easier solution is to not use xi18n from the plugins. This patch fixes some
  of the most common used among these nested calls.
  
  Task T926

REPOSITORY
  rARK Ark

BRANCH
  fix-plugins-xi18nc

REVISION DETAIL
  https://phabricator.kde.org/D745

AFFECTED FILES
  plugins/libarchive/libarchivehandler.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel


More information about the Kde-utils-devel mailing list