Review Request 126528: Fixed formatting of copied number

[Dzmitry Rudkouski]

> On Jan. 2, 2016, 7:07 p.m., Boudhayan Gupta wrote:
> > kcalcdisplay.cpp, line 262
> > <https://git.reviewboard.kde.org/r/126528/diff/1/?file=426098#file426098line262>
> >
> >     You're declaring a new variable inside a switch label, so please put these lines (except the break statement) inside a brace-delimited block.
> >     
> >     Note that if you copy my code from above, it doesn't declare new vars so you don't have to put that inside braces.
> 
> Boudhayan Gupta wrote:
>     Oh wait, I'm declaring `quint64 num` - you'll have to put it in braces.

Your code works not as expected, and, i think, there is no need to make computations to return again from text to qint64. I am added braces to my patch, it works as expected.


- Dzmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126528/#review90473
-----------------------------------------------------------


On Jan. 2, 2016, 7:52 p.m., Dzmitry Rudkouski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126528/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2016, 7:52 p.m.)
> 
> 
> Review request for KDE Utils, Christoph Feck and Evan Teran.
> 
> 
> Bugs: 356355
>     http://bugs.kde.org/show_bug.cgi?id=356355
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> Bug #356635 - KCalc shouldn't keep formatting of copied number
> 
> 
> Diffs
> -----
> 
>   kcalcdisplay.cpp 5d89896 
> 
> Diff: https://git.reviewboard.kde.org/r/126528/diff/
> 
> 
> Testing
> -------
> 
> It works perfectly. Now there is no parasite spaces beetween digits group of clipboard-copied decimal numbers.
> 
> 
> Thanks,
> 
> Dzmitry Rudkouski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160102/9ba0e7eb/attachment-0001.html>