Review Request 126756: Improve subfolder autodetection for RPM archives

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126756/
-----------------------------------------------------------

(Updated Feb. 23, 2016, 6:22 p.m.)


Status
------

This change has been discarded.


Review request for KDE Utils, Rex Dieter and Ragnar Thomsen.


Repository: ark


Description
-------

RPM archives have a couple of annoying limitations in Ark:

1. filenames start with the `./` prefix and `.` is detected as subfolder in the extraction dialog.
2. in batch extract jobs, `usr` is always going to be the autodetected subfolder name.

Fedora ships an [updated version](http://pkgs.fedoraproject.org/cgit/rpms/ark.git/tree/ark-15.12.0-improve_subfolder_autodetection.patch) of the patch in RR [107634](https://git.reviewboard.kde.org/r/107634/), to fix the above issues.
However their patch may break possible corner cases (see Kevin's comment in the linked RR), and it's probably the reason why it was never merged upstream.

Since the issue is with RPM archives, I propose a simplified version of the patch that only affects RPM archives.


Diffs
-----

  app/batchextract.cpp 3c62c60 
  kerfuffle/archive_kerfuffle.h 973d636 
  kerfuffle/archive_kerfuffle.cpp 4cec770 
  kerfuffle/jobs.cpp 6ff5fd7 

Diff: https://git.reviewboard.kde.org/r/126756/diff/


Testing
-------

1. Right click a RPM from Dolphin -> Extract here + autodetect subfolder -> The archive's basename is used as subfolder.
2. Open the RPM with Ark and open the extraction dialog -> `.` is not anymore detected as the subfolder name.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160223/552fd82c/attachment.html>