Review Request 127003: KF5 port : Port away from kdebug to use qDebug

Luigi Toscano luigi.toscano at tiscali.it
Mon Feb 8 12:26:55 UTC 2016



> On Feb. 7, 2016, 7:09 p.m., Luigi Toscano wrote:
> > At this point, I would strongly suggest to use qCDebug instead to not lose the categorized logging.
> 
> Yoann Laissus wrote:
>     Currently, KDF still uses Qt4 / KDE 4 libs so qCDebug isn't available.
>     This patch was just to ease the review process for the port to KF5 / Qt5 by making a more reasonable diff. (#126139)
>     Once the port achieved, the next step will be to port to qCDebug.

So please leave kDebug and port it properly in the frameworks branch or when master becomes frameworks-based.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127003/#review92124
-----------------------------------------------------------


On Feb. 8, 2016, 1:11 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127003/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 1:11 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Repository: kdf
> 
> 
> Description
> -------
> 
> KF5 port : Replace all kDebug by their qDebug equivalent.
> It also get rid of a legacy test class which still use Qt3Support.
> 
> It's the first step before the real port : see #126139
> 
> 
> Diffs
> -----
> 
>   disklist.cpp 12e12353748bbc46db013b90b5292c0cfa8f6c2f 
>   disks.cpp 83f9729021fd24e2a19d333f5ef1503d7760e684 
>   kconftest.cpp 05d09d372a09f72be8134c77f956919d24182c9c 
>   kdf.cpp c1f8aa64526623a60b37c65319c6e933d66d3e35 
>   kdfwidget.cpp 9312365631e6e766e5700c57ec17b1064073ed67 
>   kwikdisk.cpp 713ebfc056c82a4101b736f46b4803e75db7e7e0 
>   mntconfig.cpp 33cd92a9b3325dca4d4b2038b904f9ee8d16e71f 
> 
> Diff: https://git.reviewboard.kde.org/r/127003/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160208/7620a44e/attachment.html>


More information about the Kde-utils-devel mailing list