[Differential] [Requested Changes To] D3742: Fix sorting

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Mon Dec 19 21:01:05 UTC 2016


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Please also drop `ArchiveEntry::returnDirEntries()`, it was only used in sort() and now we don't need it anymore

INLINE COMMENTS

> archivesortfiltermodel.cpp:23
> +#include "archivesortfiltermodel.h"
> +#include "ark_debug.h"
> +#include "archiveentry.h"

Unused include

> archivesortfiltermodel.h:26
> +
> +class ArchiveModel;
> +

Unused forward declaration

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D3742

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161219/24e05dc2/attachment.html>


More information about the Kde-utils-devel mailing list