Review Request 128522: [KCharSelect] Add bookmarks support

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128522/
-----------------------------------------------------------

(Updated Aug. 18, 2016, 12:53 p.m.)


Review request for KDE Utils and David Faure.


Changes
-------

- Prepend displayed character to bookmark
- Rebase on current master


Bugs: 242333
    http://bugs.kde.org/show_bug.cgi?id=242333


Repository: kcharselect


Description
-------

Added a standard Bookmarks menu. The bookmarks are named U+xxxxx for the currently selected character.

Two issues:

1. Is there a way to actually get an "Add Bookmark" dialog? The bookmarks are silently added.

2. I blindly copied the "filename" stuff from other code I have seen. To me it looks like the bookmarks are then not editable, if the system already has a bookmarks file?


Diffs (updated)
-----

  CMakeLists.txt 6db5c66 
  kcharselectdia.h 27515a4 
  kcharselectdia.cc 28d65f9 
  kcharselectui.rc d8556ee 

Diff: https://git.reviewboard.kde.org/r/128522/diff/


Testing
-------

Tested with kwidgetsaddons from master.
To test with older frameworks: "currentCodePoint()" -> "currentChar().unicode()"
"setCurrentCodePoint(uc)" -> "setCurrentChar(QChar(uc))"


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160818/da5ceddf/attachment.html>