Review Request 128569: Avoid crash when handling RDP error and xfreerdp quits.

[Urs Wolfer]

> On Aug. 2, 2016, 4:41 p.m., Urs Wolfer wrote:
> > Thanks, looks good. I think it could fix the referenced issue. I assume you were able to reproduce the described issue without the fix? If you cannot commit by yourself, please let me know.
> 
> Matthew Dawson wrote:
>     I'll commit it and close the bug.  I couldn't reproduce the exactly, as I couldn't connect to my server (due to other reasons not related to krdc).  But I saw the crash when it failed to connect, which I went after.  The bug report looks similar, and the code behaviour matches what I expect caused the issue.
>     
>     Do you prefer me to merge the branch to master?  Or would you prefer to?
>     
>     Thanks for the review!

Once you have committed it to Applications/16.08, feel free to merge it into master.


- Urs


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128569/#review98016
-----------------------------------------------------------


On Aug. 1, 2016, 5:28 p.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128569/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 5:28 p.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Bugs: 365054
>     http://bugs.kde.org/show_bug.cgi?id=365054
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> If xfreerdp sent a failure message then quit, the RDP plugin would first
> show a message box with a relevant message.  During that time, the inner
> event loop would handle the xfreerdp process quitting, which would signal
> krdc to cleanup the RDP plugin's resources.  When the message box event loop
> completed, the RdpView would have been destroyed, causing a crash.
> 
> Now the RdpView signals that the view is quitting as soon as the message box
> is shown, and avoids trying to quit twice if another part signals a quit.
> Once the message box is dismissed, the process continues as normal.  This
> adds the necessary mechanisms to handle this, as well as moving the message
> box display code to connectionError, to avoid some duplication.
> 
> BUG: 365054
> REVIEW: 128569
> 
> I've listed the above bug, as I suspect it is part of this issue, but I'm not sure.  I'll take out the reference if desired.
> 
> 
> Diffs
> -----
> 
>   rdp/rdpview.h 0980c8d83d08b6e860af0d5b456a5b040f6aae80 
>   rdp/rdpview.cpp 7f6081277919a41e35456d8069e5fc7cad23e9ad 
> 
> Diff: https://git.reviewboard.kde.org/r/128569/diff/
> 
> 
> Testing
> -------
> 
> Before, when attempting a connection to an unreachable RDP server the app crashed after dismissing the dialogue box.
> 
> After, it no longer does.  Everything appears to still clean up.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160802/98fbf425/attachment-0001.html>