[Maniphest] [Created] T2374: Fix broken preview
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Wed Apr 27 19:41:22 UTC 2016
elvisangelaccio created this task.
elvisangelaccio moved this task to In progress on the Ark workboard.
TASK DESCRIPTION
Commit https://phabricator.kde.org/rARK8c21ca3ae9326d772e2f037c4f79ba9ca10af6ad on stable branch broke the ArkViewer preview (as well as the Open File action).
In particular, removing the `archiveInterface()->disconnect(this);` line is the root cause. This line was removed to fix a crash, so we cannot restore it.
Dropping the `job->setAutoDelete(false);` call in `Archive::list()` fixes the issue, but we need to be sure to not introduce other regressions. This change was added a long time ago in commit https://phabricator.kde.org/rARK4b67603dea6d5e45f2c3e3fabaf7692a21908b0b, to fix this bug: http://bugs.kde.org/show_bug.cgi?id=217836
TASK DETAIL
https://phabricator.kde.org/T2374
WORKBOARD
https://phabricator.kde.org/project/board/46/
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio
Cc: kde-utils-devel, elvisangelaccio, tctara
More information about the Kde-utils-devel
mailing list