[Differential] [Request, 253 lines] D1493: Add support for editing comments

[rthomsen (Ragnar Thomsen)]

rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.

REVISION SUMMARY
  Support was added for editing comments in supported archive types (currently only RAR). A new bool was added to plugin json files ("SupportsWriteComment") to indicate support. A new action (Edit Comment) was added and is found in Archive menu. The editing of comment is done in the same QPlainTextEdit used to display comment before. When user modifies comment, a KMessageWidget pops up with a "Save" button. Actual saving of comment to archive is achieved by a new job type (CommentJob).
  
  F115733: edit-comment-1.png <https://phabricator.kde.org/F115733>

TEST PLAN
  - All unit tests pass.
  - Open RAR archive with comment -> QPlaintTextEdit is visible and editable.
  - Open Zip archive with comment -> QPlaintTextEdit is visible and readonly.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1493

AFFECTED FILES
  autotests/kerfuffle/jsonarchiveinterface.cpp
  autotests/kerfuffle/jsonarchiveinterface.h
  kerfuffle/archive_kerfuffle.cpp
  kerfuffle/archive_kerfuffle.h
  kerfuffle/archiveformat.cpp
  kerfuffle/archiveformat.h
  kerfuffle/archiveinterface.h
  kerfuffle/cliinterface.cpp
  kerfuffle/cliinterface.h
  kerfuffle/jobs.cpp
  kerfuffle/jobs.h
  part/ark_part.rc
  part/part.cpp
  part/part.h
  plugins/clirarplugin/cliplugin.cpp
  plugins/clirarplugin/kerfuffle_clirar.json
  plugins/libarchive/libarchiveplugin.cpp
  plugins/libarchive/libarchiveplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara