[Differential] [Request, 15 lines] D1466: Properly kill libarchive AddJobs
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Sat Apr 23 12:10:18 UTC 2016
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.
REVISION SUMMARY
We just need use the m_abortOperation flag, like we already do for ListJobs.
However killing an AddToArchive jobs still would crash Ark. Dropping the
disconnect() in the Job dtor seems to fix this.
TEST PLAN
libarchive AddJobs are now properly killed (both using the systray button or
closing the Ark window).
cliinterface is still broken for now.
REPOSITORY
rARK Ark
BRANCH
missing-aborts
REVISION DETAIL
https://phabricator.kde.org/D1466
AFFECTED FILES
kerfuffle/jobs.cpp
plugins/libarchive/libarchiveplugin.h
plugins/libarchive/readwritelibarchiveplugin.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
More information about the Kde-utils-devel
mailing list