[Differential] [Request, 55 lines] D1459: Fix threading code for libarchive jobs

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Thu Apr 21 14:28:57 UTC 2016


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  This patch refactors and simplifies the threading code in jobs.cpp
  
  Our Job::Private class is not anymore a QThread, but just a worker.
  
  We move the worker to another thread using the moveToThread functions and then
  we set up the needed connect()s. This seems enough to properly quit the thread
  upon jobs killing.

TEST PLAN
  Tests pass. I cannot reproduce anymore bug #222392

REPOSITORY
  rARK Ark

BRANCH
  fix-threads

REVISION DETAIL
  https://phabricator.kde.org/D1459

AFFECTED FILES
  kerfuffle/jobs.cpp
  kerfuffle/jobs.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list