[Differential] [Request, 24 lines] D1408: Don't set ArkViewer as child of Part::widget()

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Thu Apr 14 13:33:48 UTC 2016


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio added a subscriber: kde-utils-devel.
elvisangelaccio set the repository for this revision to rARK Ark.
elvisangelaccio added a project: Ark.

REVISION SUMMARY
  `ArkViewer` currently has the `Part::widget()` as parent. This prevents the main window to gain focus if one or more `ArkViewer` dialogs are open.
  
  Removing the parent fixes the issue, but we need to set the `Qt::WA_DeleteOnClose` attribute, otherwise the widget will not be deleted causing leaks.
  
  (fix meant for Applications/16.04)

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1408

AFFECTED FILES
  part/arkviewer.cpp
  part/arkviewer.h
  part/part.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list