[Differential] [Accepted] D1364: Implement GUI for setting compression level
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Sat Apr 9 19:15:27 UTC 2016
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.
Great work, just some more minor nitpicks.
INLINE COMMENTS
kerfuffle/archiveformat.h:61-63 Do you mind renaming these `min/max/defaultCompressionLevel()` ?
kerfuffle/cliinterface.cpp:723 `if (level < 0) || level > 9)` is more bullet-proof ;)
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D1364
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
More information about the Kde-utils-devel
mailing list