[Differential] [Request, 106 lines] D1369: Move GlobalWorkDir logic to AddJob::doWork()
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Sat Apr 9 13:39:58 UTC 2016
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.
REVISION SUMMARY
With this patch, we change the working dir to GlobalWorkDir at the AddJob
level. This way is easier to restore the old working dir, and we also avoid
some duplicated code between cliinterface and libarchiveplugin.
Note that the libarchive plugin used to add trailing slashes to relative folder
paths, while CliInterface didn't. Both plugins now receive relative folders
already with a trailing slash. This doesn't seem to change how
CliInterface::addFiles works.
REPOSITORY
rARK Ark
BRANCH
fix-addfiles-chdir
REVISION DETAIL
https://phabricator.kde.org/D1369
AFFECTED FILES
autotests/plugins/cli7zplugin/cli7ztest.cpp
autotests/plugins/clirarplugin/clirartest.cpp
kerfuffle/cliinterface.cpp
kerfuffle/cliinterface.h
kerfuffle/jobs.cpp
kerfuffle/jobs.h
plugins/libarchive/readwritelibarchiveplugin.cpp
plugins/libarchive/readwritelibarchiveplugin.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
More information about the Kde-utils-devel
mailing list