Review Request 125096: Fix encryption support for cliplugins supporting multiple mimetypes with different encryption support

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125096/
-----------------------------------------------------------

(Updated Sept. 24, 2015, 4:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.


Changes
-------

Submitted with commit bc0e2c199f3cae4e0fc7a4ec4e063a272ceee94f by Ragnar Thomsen to branch master.


Repository: ark


Description
-------

Currently, support for encryption of entries and/or header is stated in the desktop file for each plugin by two booleans (`X-KDE-Kerfuffle-EncryptEntries` and `X-KDE-Kerfuffle-EncryptHeader`). This provides a problem when a plugin supports multiple mimetypes, and the mimetypes differ in their support for encryption forms. E.g. cli7z supports both zip and 7z archives, and zip archives only support entry encryption while 7z archives support both encryption forms. The current implementation results in the header encryption checkbox in CreateDialog being enabled for zip archives, which it shouldn't.

This patch changes the two parameters to be StringLists containing the mimetypes that support the two forms of encryption. The two properties are then used in supportedEncryptEntriesMimeTypes() and supportedEncryptHeaderMimeTypes().


Diffs
-----

  kerfuffle/archive_kerfuffle.cpp 44fc0fe 
  kerfuffle/kerfufflePlugin.desktop a5da4f6 
  plugins/cli7zplugin/CMakeLists.txt 45fc3b2 
  plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake 2b0cfce 
  plugins/clirarplugin/CMakeLists.txt 8d7048f 
  plugins/clirarplugin/kerfuffle_clirar.desktop.cmake 64f2dd9 
  plugins/clizipplugin/CMakeLists.txt 817520f 
  plugins/clizipplugin/kerfuffle_clizip.desktop.cmake f745dbb 

Diff: https://git.reviewboard.kde.org/r/125096/diff/


Testing
-------

Creating encrypted rar, zip and 7z archives works. Header encryption checkbox is disabled for zip archives.


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150924/9269d71c/attachment-0001.html>