Review Request 125096: Fix encryption support for cliplugins supporting multiple mimetypes with different encryption support

[Ragnar Thomsen]

> On Sept. 24, 2015, 4 p.m., Elvis Angelaccio wrote:
> > plugins/cli7zplugin/CMakeLists.txt, line 4
> > <https://git.reviewboard.kde.org/r/125096/diff/1/?file=402175#file402175line4>
> >
> >     Shouldn't the mimetypes be separated by a semicolon? I don't know if commas and semicolons are the same for cmake, but let's just be consistent with what we already have in the line above.

The Type of the two custom fields is QStringList. It only accepts comma-separated lists, semicolons unfortunately do not work.


- Ragnar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125096/#review85871
-----------------------------------------------------------


On Sept. 7, 2015, 10:05 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125096/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 10:05 p.m.)
> 
> 
> Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Currently, support for encryption of entries and/or header is stated in the desktop file for each plugin by two booleans (`X-KDE-Kerfuffle-EncryptEntries` and `X-KDE-Kerfuffle-EncryptHeader`). This provides a problem when a plugin supports multiple mimetypes, and the mimetypes differ in their support for encryption forms. E.g. cli7z supports both zip and 7z archives, and zip archives only support entry encryption while 7z archives support both encryption forms. The current implementation results in the header encryption checkbox in CreateDialog being enabled for zip archives, which it shouldn't.
> 
> This patch changes the two parameters to be StringLists containing the mimetypes that support the two forms of encryption. The two properties are then used in supportedEncryptEntriesMimeTypes() and supportedEncryptHeaderMimeTypes().
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archive_kerfuffle.cpp 44fc0fe 
>   kerfuffle/kerfufflePlugin.desktop a5da4f6 
>   plugins/cli7zplugin/CMakeLists.txt 45fc3b2 
>   plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake 2b0cfce 
>   plugins/clirarplugin/CMakeLists.txt 8d7048f 
>   plugins/clirarplugin/kerfuffle_clirar.desktop.cmake 64f2dd9 
>   plugins/clizipplugin/CMakeLists.txt 817520f 
>   plugins/clizipplugin/kerfuffle_clizip.desktop.cmake f745dbb 
> 
> Diff: https://git.reviewboard.kde.org/r/125096/diff/
> 
> 
> Testing
> -------
> 
> Creating encrypted rar, zip and 7z archives works. Header encryption checkbox is disabled for zip archives.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150924/c1e009b7/attachment.html>