Review Request 125221: Check readability when opening an archive

[Elvis Angelaccio]

> On Set. 14, 2015, 7:57 a.m., Ragnar Thomsen wrote:
> > Looks good. Should we change the preceding exists() check to display a KMessageWidget also?

Yes. Actually we should replace every "OK only" KMessageBox with a KMessageWidget, or at least the ones in part.cpp. It's worth doing a separate patch for this.


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125221/#review85348
-----------------------------------------------------------


On Set. 13, 2015, 10:40 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125221/
> -----------------------------------------------------------
> 
> (Updated Set. 13, 2015, 10:40 p.m.)
> 
> 
> Review request for KDE Utils, Raphael Kubo da Costa and Ragnar Thomsen.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Ark does not currently check if an archive being opened is actually readable by the user. With this patch, a KMessageWidget with a warning message is shown to the user.
> 
> 
> Diffs
> -----
> 
>   part/part.cpp fbf5757eb848ac3edc66879dcb52e752e727852e 
> 
> Diff: https://git.reviewboard.kde.org/r/125221/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150914/facdf188/attachment.html>